zentol commented on code in PR #20893:
URL: https://github.com/apache/flink/pull/20893#discussion_r980213947
##########
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/conditions/SimpleCondition.java:
##########
@@ -40,4 +40,13 @@
public boolean filter(T value, Context<T> ctx) throws Exception {
return filter(value);
}
+
+ public static <T> SimpleCondition<T> of(FilterFunction<T> filters) {
Review Comment:
> replace the `Condition` with the `FilterFunction`
I'm not sure I understand. Which `Condition` to do you want to _replace_?
> other condition implementation should follow this usage
I'm not sure this is needed; AFAICT all other IterativeCondition sub-classes
are truly internal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
