zentol commented on code in PR #20893:
URL: https://github.com/apache/flink/pull/20893#discussion_r984453514
##########
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/conditions/SimpleCondition.java:
##########
@@ -40,4 +40,13 @@
public boolean filter(T value, Context<T> ctx) throws Exception {
return filter(value);
}
+
+ public static <T> SimpleCondition<T> of(FilterFunction<T> filters) {
Review Comment:
At the end of the day this doesn't need to be the final solution.
While `Pattern#where(FilterFunction)` is a lot more user-friendly this would
be a breaking change, because an existing `SimpleCondition` would satisfy both
signatures which the compiler rejects.
I'd like to avoid using different method names for the `FilterFunction`
variants.
We could also modify `SimpleCondition` to not implement the `FilterFunction`
interface, but this would again be a potentially breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
