Github user s1ck commented on a diff in the pull request:
https://github.com/apache/flink/pull/2527#discussion_r80186110
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/Summarization.java
---
@@ -226,11 +247,15 @@ public void setGroupRepresentativeId(K
groupRepresentativeId) {
}
public VGV getVertexGroupValue() {
- return f2;
+ return f2.isLeft() ? f2.left() : null;
}
public void setVertexGroupValue(VGV vertexGroupValue) {
- f2 = vertexGroupValue;
+ if (vertexGroupValue == null) {
+ f2 = new
Either.Right<>(NullValue.getInstance());
--- End diff --
An instance of `VertexGroupItem` is reused in the `VertexGroupReducer`.
Here the setter is implicitly only called once in the open method. So I thought
reusing the new Right<>(NullValue.getInstance()) wouldn't be a benefit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
