[
https://issues.apache.org/jira/browse/FLINK-4624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515524#comment-15515524
]
ASF GitHub Bot commented on FLINK-4624:
---------------------------------------
Github user s1ck commented on a diff in the pull request:
https://github.com/apache/flink/pull/2527#discussion_r80186110
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/Summarization.java
---
@@ -226,11 +247,15 @@ public void setGroupRepresentativeId(K
groupRepresentativeId) {
}
public VGV getVertexGroupValue() {
- return f2;
+ return f2.isLeft() ? f2.left() : null;
}
public void setVertexGroupValue(VGV vertexGroupValue) {
- f2 = vertexGroupValue;
+ if (vertexGroupValue == null) {
+ f2 = new
Either.Right<>(NullValue.getInstance());
--- End diff --
An instance of `VertexGroupItem` is reused in the `VertexGroupReducer`.
Here the setter is implicitly only called once in the open method. So I thought
reusing the new Right<>(NullValue.getInstance()) wouldn't be a benefit.
> Gelly's summarization algorithm cannot deal with null vertex group values
> -------------------------------------------------------------------------
>
> Key: FLINK-4624
> URL: https://issues.apache.org/jira/browse/FLINK-4624
> Project: Flink
> Issue Type: Bug
> Components: Gelly
> Reporter: Till Rohrmann
> Assignee: Martin Junghanns
> Fix For: 1.2.0
>
>
> Gelly's {{Summarization}} algorithm cannot handle null values in the
> `VertexGroupItem.f2`. This behaviour is hidden by using Strings as a vertex
> value in the {{SummarizationITCase}}, because the {{StringSerializer}} can
> handle null values.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
