[
https://issues.apache.org/jira/browse/FLINK-4624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15517351#comment-15517351
]
ASF GitHub Bot commented on FLINK-4624:
---------------------------------------
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/2527#discussion_r80309626
--- Diff:
flink-libraries/flink-gelly-examples/src/test/java/org/apache/flink/graph/library/SummarizationITCase.java
---
@@ -100,23 +102,41 @@ public void testWithVertexAndAbsentEdgeValues()
throws Exception {
validateEdges(SummarizationData.EXPECTED_EDGES_ABSENT_VALUES,
summarizedEdges);
}
- private void validateVertices(String[] expectedVertices,
-
List<Vertex<Long,
Summarization.VertexValue<String>>> actualVertices) {
+ @Test
+ public void testWithVertexAndEdgeLongValues() throws Exception {
+ ExecutionEnvironment env =
ExecutionEnvironment.getExecutionEnvironment();
+
+ Graph<Long, Long, Long> input = Graph.fromDataSet(
+ SummarizationData.getVertices(env),
+ SummarizationData.getEdges(env),
+ env)
+ .run(new TranslateVertexValues<Long, String, Long,
String>(new StringToLong()))
+ .run(new TranslateEdgeValues<Long, Long, String,
Long>(new StringToLong()));
+
+ List<Vertex<Long, Summarization.VertexValue<Long>>>
summarizedVertices = Lists.newArrayList();
--- End diff --
Can replace Guava's `Lists.newArrayList()` with `new ArrayList<>()`.
> Gelly's summarization algorithm cannot deal with null vertex group values
> -------------------------------------------------------------------------
>
> Key: FLINK-4624
> URL: https://issues.apache.org/jira/browse/FLINK-4624
> Project: Flink
> Issue Type: Bug
> Components: Gelly
> Reporter: Till Rohrmann
> Assignee: Martin Junghanns
> Fix For: 1.2.0
>
>
> Gelly's {{Summarization}} algorithm cannot handle null values in the
> `VertexGroupItem.f2`. This behaviour is hidden by using Strings as a vertex
> value in the {{SummarizationITCase}}, because the {{StringSerializer}} can
> handle null values.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
