zentol commented on code in PR #21019:
URL: https://github.com/apache/flink/pull/21019#discussion_r992371711
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java:
##########
@@ -841,6 +842,12 @@ private StreamConfig createJobVertex(Integer streamNodeId,
OperatorChainInfo cha
},
serializationExecutor));
}
+ coordinatorSerializationFutures.add(
+ FutureUtils.combineAll(serializationFutures)
+ .thenAccept(
+ serializedCoordinators ->
+ serializedCoordinators.forEach(
+
jobVertex::addOperatorCoordinator)));
Review Comment:
hmm. This isn't quite what I had in mind TBH; you still have multiple
threads modifying the `JobGraph`; it "only" works because they touch different
job vertices.
Rather I wanted the `coordinatorSerializationFutures` to return a sort of
`Map<JobVertex, Collection<SerializedValue>>` that we'd wait for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
