[GitHub] [flink] XComp commented on a diff in pull request #21019: [FLINK-29576][runtime] Adds concurrency support to JobVertex#addOperatorCoordinator

[GitBox]

XComp commented on code in PR #21019:
URL: https://github.com/apache/flink/pull/21019#discussion_r992375638


##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java:
##########
@@ -841,6 +842,12 @@ private StreamConfig createJobVertex(Integer streamNodeId, 
OperatorChainInfo cha
                             },
                             serializationExecutor));
         }
+        coordinatorSerializationFutures.add(
+                FutureUtils.combineAll(serializationFutures)
+                        .thenAccept(
+                                serializedCoordinators ->
+                                        serializedCoordinators.forEach(
+                                                
jobVertex::addOperatorCoordinator)));

Review Comment:
   ok, I didn't think that far. :+1: 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org