[
https://issues.apache.org/jira/browse/FLINK-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526103#comment-15526103
]
ASF GitHub Bot commented on FLINK-4695:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2555
I don't really see the benefit here. Instead of the MetricRegistry being
coupled got the globalconfig the MetricRegistryConfiguration now is. This looks
a lot like moving code around for the sake of moving it around.
> Separate configuration parsing from MetricRegistry
> --------------------------------------------------
>
> Key: FLINK-4695
> URL: https://issues.apache.org/jira/browse/FLINK-4695
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.2.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
>
> In order to decouple the {{MetricRegistry}} object instantiation from the
> global configuration, we could introduce a {{MetricRegistryConfiguration}}
> object which encapsulates all necessary information for the
> {{MetricRegistry}}. The {{MetricRegistryConfiguration}} could have a static
> method to be generated from a {{Configuration}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
