[
https://issues.apache.org/jira/browse/FLINK-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526182#comment-15526182
]
ASF GitHub Bot commented on FLINK-4695:
---------------------------------------
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2555
True, the benefit of this is only marginal in the current master. It is
actually part of the `TaskManager` services start up logic in Flip-6. In this
branch, the services will be generated by providing component specific
configurations objects. These objects are generated from the global
configuration and only contain component specific fields. That way, we decouple
components from the global configuration object.
In order to avoid future merge conflicts between Flip-6 and the master
branch, I wanted to merge this specific commit to the master. I should have
stated this earlier.
> Separate configuration parsing from MetricRegistry
> --------------------------------------------------
>
> Key: FLINK-4695
> URL: https://issues.apache.org/jira/browse/FLINK-4695
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.2.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
>
> In order to decouple the {{MetricRegistry}} object instantiation from the
> global configuration, we could introduce a {{MetricRegistryConfiguration}}
> object which encapsulates all necessary information for the
> {{MetricRegistry}}. The {{MetricRegistryConfiguration}} could have a static
> method to be generated from a {{Configuration}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
