gaborgsomogyi commented on code in PR #21457:
URL: https://github.com/apache/flink/pull/21457#discussion_r1041217298
##########
flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java:
##########
@@ -217,6 +217,16 @@ public class SecurityOptions {
.withDescription(
"Turns on SSL for external communication via the
REST endpoints.");
+ @Documentation.Section(Documentation.Sections.EXPERT_SECURITY_SSL)
+ public static final ConfigOption<String> SSL_REST_SSL_CONTEXT_SUPPLIER =
+ key("security.ssl.rest.ssl-context-supplier")
+ .stringType()
+ .noDefaultValue()
+ .withDescription(
+ "A fully qualified class name that implements the
Supplier<SslContext> interface."
+ + " The implementation must have a public
constructor with the signature"
+ + " (Configuration config, boolean
isClient, SslProvider sslProvider)");
Review Comment:
Easy to pass inside the code should never drive the API. Having a factory of
a factory is -1 from my side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
