gaborgsomogyi commented on PR #21457:
URL: https://github.com/apache/flink/pull/21457#issuecomment-1354982332
I've taken a look at it again. My summary is that we want to introduce a
supplier of `SSLContext` which fine. Which I personally still don't understand
why suppliers are scattered around in the code back and forth like
`Supplier<SSLServerSocketFactory>` etc...
I've not spent days to re-implement it but why not enough to do like this?
The internal implementation of the custom context can handle any logic, right?
```
SslContext sslContext;
SslContextSupplier supplier = getIfConfigured();
if (supplier == null) {
sslContext = createInternalNettySSLContext();
} else {
sslContext = supplier.get(...);
}
```
This could be copy-pasted to the REST area.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
