[ 
https://issues.apache.org/jira/browse/FLINK-4738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15548104#comment-15548104
 ] 

ASF GitHub Bot commented on FLINK-4738:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/2594

    [FLINK-4738] [TaskManager] Port TaskManager logic to new Flip-6 TaskManager

    The ported logic contains the task lifecycle management methods, JobManager 
association and
    setup of TaskManager components. Most of the code is simply ported from 
Scala. I made some changes to the thrown exceptions which are now checked 
exceptions. 
    
    The PR is only a first step towards the full implementation of the 
`TaskExecutor`. But in order to let the changes not grow too big, I'd like to 
merge this as a first step.
    
    I also tried to replace logic in the `TaskManager` by the newly implemented 
code. That way we'll be notified whenever things change in the master and have 
to be ported to the new code. So for example, the metric initialization is now 
encapsulated in the `TaskExecutorMetricsInitializer`.
    
    Be aware that the code does not yet contain test cases for the 
`TaskExecutor`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink taskManagerLogic

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2594.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2594
    
----
commit bbebd4034107d330d7b0f94dfa06a4392a06dba6
Author: Till Rohrmann <[email protected]>
Date:   2016-09-28T12:39:51Z

    [FLINK-4738] [TaskManager] Port TaskManager logic to new Flip-6 TaskManager
    
    The ported logic contains the task lifecycle management methods, JobManager 
association and
    setup of TaskManager components.
    
    Introduce Rpc implementations for TaskManager components
    
    Implement metrics setup

----


> Port TaskManager logic to TaskExecutor
> --------------------------------------
>
>                 Key: FLINK-4738
>                 URL: https://issues.apache.org/jira/browse/FLINK-4738
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>
> Port the basic operations of the {{TaskManager}} to the {{TaskExecutor}}. 
> These operations include the task lifecycle methods, {{JobManager}} 
> association logic and setup of TaskManager components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to