[ 
https://issues.apache.org/jira/browse/FLINK-4738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15557339#comment-15557339
 ] 

ASF GitHub Bot commented on FLINK-4738:
---------------------------------------

Github user KurtYoung commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2594#discussion_r82496723
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorGateway.java
 ---
    @@ -0,0 +1,43 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.checkpoint;
    +
    +import org.apache.flink.api.common.JobID;
    +import org.apache.flink.runtime.executiongraph.ExecutionAttemptID;
    +import org.apache.flink.runtime.rpc.RpcGateway;
    +import org.apache.flink.runtime.state.CheckpointStateHandles;
    +
    +public interface CheckpointCoordinatorGateway extends RpcGateway {
    +
    +   void acknowledgeCheckpoint(
    +           JobID jobID,
    +           ExecutionAttemptID executionAttemptID,
    +           long checkpointID,
    +           CheckpointStateHandles checkpointStateHandles,
    +           long synchronousDurationMillis,
    +           long asynchronousDurationMillis,
    +           long bytesBufferedInAlignment,
    +           long alignmentDurationNanos);
    +
    +   void declineCheckpoint(
    +           JobID jobID,
    --- End diff --
    
    Same above, reuse DeclineCheckpoint?


> Port TaskManager logic to TaskExecutor
> --------------------------------------
>
>                 Key: FLINK-4738
>                 URL: https://issues.apache.org/jira/browse/FLINK-4738
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>
> Port the basic operations of the {{TaskManager}} to the {{TaskExecutor}}. 
> These operations include the task lifecycle methods, {{JobManager}} 
> association logic and setup of TaskManager components.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to