fredia commented on code in PR #21547:
URL: https://github.com/apache/flink/pull/21547#discussion_r1069245033
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksDBSnapshotStrategyBase.java:
##########
@@ -325,6 +329,7 @@ protected RocksDBSnapshotOperation(
this.checkpointStreamFactory = checkpointStreamFactory;
this.stateMetaInfoSnapshots = stateMetaInfoSnapshots;
this.localBackupDirectory = localBackupDirectory;
+ this.tmpResourcesRegistry = new CloseableRegistry();
Review Comment:
Can `tmpResourcesRegistry` be reused by multiple checkpoints?
Suppose chk-1 left some files because of the timeout, `tmpResourcesRegistry`
would clean these files and close; if chk-2 also timeout again,
`tmpResourcesRegistry.registerCloseable()` would throw `IOException` as
`testUploadedSstCanBeCleanedUp()` shown, is this as expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
