fredia commented on code in PR #21547:
URL: https://github.com/apache/flink/pull/21547#discussion_r1070245915
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksDBSnapshotStrategyBase.java:
##########
@@ -325,6 +329,7 @@ protected RocksDBSnapshotOperation(
this.checkpointStreamFactory = checkpointStreamFactory;
this.stateMetaInfoSnapshots = stateMetaInfoSnapshots;
this.localBackupDirectory = localBackupDirectory;
+ this.tmpResourcesRegistry = new CloseableRegistry();
Review Comment:
Thanks for the clarification, I forgot that the RocksDBSnapshotOperation is
created for single checkpoint😊.
And I have another question: will
“`tmpResourcesRegistry.registerCloseable()` throw `IOException` after
`close()`” cause the job to failover? If we set
`execution.checkpointing.tolerable-failed-checkpoints` to infinity, if chk-1
timeout, will the job continue to run?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
