dawidwys commented on code in PR #21635:
URL: https://github.com/apache/flink/pull/21635#discussion_r1081388117


##########
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerSnapshot.java:
##########
@@ -56,6 +55,9 @@
     /** Contains the actual content for the serializer snapshot. */
     private PojoSerializerSnapshotData<T> snapshotData;
 
+    /** Configuration of the current execution. */
+    private ExecutionConfig executionConfig;

Review Comment:
   After thinking over it for a while I somewhat softened my opinion here.
   
   Yes, it is messy, but I think we're forced to do it that way :( Do you mind 
adding a big, strong warning next to the `executionConfig` that it should 
never, under any circumstances end up serialized?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to