dawidwys commented on code in PR #21635:
URL: https://github.com/apache/flink/pull/21635#discussion_r1081546445
##########
flink-python/src/main/java/org/apache/flink/table/runtime/typeutils/serializers/python/MapDataSerializer.java:
##########
@@ -227,25 +225,22 @@ public void readSnapshot(int readVersion, DataInputView
in, ClassLoader userCode
@Override
public TypeSerializer<MapData> restoreSerializer() {
- return new MapDataSerializer(
- previousKeyType,
- previousValueType,
- previousKeySerializer,
- previousValueSerializer);
+ return new MapDataSerializer(keyType, valueType, keySerializer,
valueSerializer);
}
@Override
public TypeSerializerSchemaCompatibility<MapData>
resolveSchemaCompatibility(
- TypeSerializer<MapData> newSerializer) {
- if (!(newSerializer instanceof MapDataSerializer)) {
+ TypeSerializerSnapshot<MapData> oldSerializerSnapshot) {
+ if (!(oldSerializerSnapshot instanceof BaseMapSerializerSnapshot))
{
Review Comment:
Why has the type changed in the check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
