pnowojski commented on code in PR #20151:
URL: https://github.com/apache/flink/pull/20151#discussion_r1082365656


##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/ExecutionCheckpointingOptions.java:
##########
@@ -280,4 +280,13 @@ public class ExecutionCheckpointingOptions {
                     .booleanType()
                     .defaultValue(false)
                     .withDescription("Flag to enable approximate local 
recovery.");
+
+    public static final ConfigOption<Integer> 
CHANNEL_STATE_NUMBER_OF_SUBTASKS_SHARE_FILE =
+            
ConfigOptions.key("execution.checkpointing.channel-state.number-of-subtasks-share-file")
+                    .intType()
+                    .defaultValue(5)
+                    .withDescription(
+                            "Defines the maximum number of subtasks that share 
the same channel state file. "
+                                    + "It can reduce the number of small files 
when enable unaligned checkpoint. "
+                                    + "Each subtask will create a new channel 
state file when this is configured to 1.");

Review Comment:
   > number-of-subtasks-share-file
   
   This sounds a bit strange in english. Maybe let's rename it to:
   
   > execution.checkpointing.channel-state.subtasks-per-file
   
   ? and renaming the config option and getters as well? @dawidwys maybe you 
have some better idea?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to