snuyanzin commented on code in PR #21934:
URL: https://github.com/apache/flink/pull/21934#discussion_r1109651676
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/DecomposeGroupingSetsRule.scala:
##########
@@ -328,7 +328,7 @@ class DecomposeGroupingSetsRule
val res: Long = call.getArgList.foldLeft(0L)(
(res, arg) => (res << 1L) + (if (groups.contains(arg)) 0L else 1L))
builder.makeLiteral(res, call.getType, false)
- case _ => builder.constantNull()
Review Comment:
Deprecated in
https://github.com/apache/calcite/commit/b432756e2be9ad0557a56254550eb4438dd0efcf
in favor of `#makeNullLiteral(RelDataType)`
because
> because it produces untyped NULL literals that make planning difficult
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
