snuyanzin commented on code in PR #21934: URL: https://github.com/apache/flink/pull/21934#discussion_r1109652438
########## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/trait/FlinkRelDistribution.scala: ########## @@ -119,7 +119,7 @@ class FlinkRelDistribution private ( try { val i = mapping.getTargetOpt(fieldCollation.getFieldIndex) if (i >= 0) { - newFieldCollations.add(fieldCollation.copy(i)) Review Comment: deprecated at https://github.com/apache/calcite/commit/4fdf241dfb8cc555ab28c6cba7a152e4cc4ec169#diff-c324ef65e6a4e0a729b606cf5f4998aa6769bed7ce52f94995b85dcee93b9d96R219-R227 in favor of `withXXX` methods ########## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/trait/TraitUtil.scala: ########## @@ -49,7 +49,7 @@ object TraitUtil { fieldCollation => try { val i = mapping.getTargetOpt(fieldCollation.getFieldIndex) - if (i >= 0) newFieldCollations.add(fieldCollation.copy(i)) Review Comment: deprecated at https://github.com/apache/calcite/commit/4fdf241dfb8cc555ab28c6cba7a152e4cc4ec169#diff-c324ef65e6a4e0a729b606cf5f4998aa6769bed7ce52f94995b85dcee93b9d96R219-R227 in favor of `withXXX` methods -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org