echauchot opened a new pull request, #22124:
URL: https://github.com/apache/flink/pull/22124
## What is the purpose of the change
While developping Cassandra source connector, I was surprised that new
splits were not automatically asked by the source reader when the previous
split was finished. I mean, as a source author, when one implements
SplitEnumerator#handleSplitRequest() one kind of expects this method to be
called by the source framework.
## Brief change log
Add a default impl in `SourceReaderBase#onSplitFinished()` that calls
`context.sendSplitRequest();`
## Verifying this change
Already covered by the existing ITests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? javadoc
R: @MartijnVisser I though, as this change is trivial, that we could discuss
in the PR rather than in the ticket. WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
