echauchot commented on PR #22124: URL: https://github.com/apache/flink/pull/22124#issuecomment-1469702666
> I don't think such a change is desirable, at least in the SourceReaderBase for generic sources. For split push based sources like Kafka/Pulsar, the implementations would not require to send a split request on split finished. @mas-chen thanks for your views. I seems to me that, as we are talking only of the default implementation here (which can be overridden by any source), the question can be reduced to "'what is the most common pattern among sources?". Are split push the most common pattern ? Anyway kafka source reader overrides this method so this change will have no impact on kafka source. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
