[GitHub] [flink] dmvk commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

[via GitHub]

dmvk commented on code in PR #22169:
URL: https://github.com/apache/flink/pull/22169#discussion_r1133610430


##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java:
##########
@@ -175,7 +173,7 @@ public class DefaultSchedulerTest extends TestLogger {
     @BeforeEach
     void setUp() {
         executor = Executors.newSingleThreadExecutor();
-        scheduledExecutorService = new DirectScheduledExecutorService();
+        scheduledExecutorService = 
Executors.newSingleThreadScheduledExecutor();

Review Comment:
   The test would get stuck otherwise due to the assertRunningInMainThread 
check (this was a bug that was hidden by waiting for time out on 
`taskManagerGateway.waitForSubmissions(1);`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org