rkhachatryan commented on code in PR #22169:
URL: https://github.com/apache/flink/pull/22169#discussion_r1136395017
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/WaitingForResources.java:
##########
@@ -144,12 +135,17 @@ public Logger getLogger() {
}
@Override
- public void notifyNewResourcesAvailable() {
+ public void onNewResourcesAvailable() {
+ checkDesiredOrSufficientResourcesAvailable();
+ }
+
+ @Override
+ public void onNewResourceRequirements() {
checkDesiredOrSufficientResourcesAvailable();
}
private void checkDesiredOrSufficientResourcesAvailable() {
- if (context.hasDesiredResources(desiredResources)) {
+ if (context.hasDesiredResources()) {
Review Comment:
Not directly related to this PR:
when `resourceStabilizationDeadline` is not null, should we skip scheduling
`checkDesiredOrSufficientResourcesAvailable` (on [line
162](https://github.com/apache/flink/pull/22169/files/88af0f06134dba8395895ba57e4ee4f24e4e4d21#diff-5128dc523e66d2349dd24b603f2bd4eb5529ad58479728e30c000c4e8ebc7fa5R162))?
Otherwise, we schedule as many checks as there are changes in resources.
Or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
