dmvk commented on code in PR #22169:
URL: https://github.com/apache/flink/pull/22169#discussion_r1140235833
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##########
@@ -1050,6 +1055,14 @@ public CreatingExecutionGraph.AssignmentResult
tryToAssignSlots(
.orElseGet(CreatingExecutionGraph.AssignmentResult::notPossible);
}
+ @Override
+ public void freeExcessiveReservedSlots() {
+ for (SlotInfo slotInfo :
declarativeSlotPool.getFreeSlotsInformation()) {
+ declarativeSlotPool.freeReservedSlot(
+ slotInfo.getAllocationId(), null,
System.currentTimeMillis());
+ }
Review Comment:
I went through the chain of differently typed callbacks; it seems that the
reserved slot is already freed when the Execution is canceled (~ when the
ExecutionGraph is canceled), which should make this a no-op. We're guaranteed
the EG is canceled before we create a new one.
Good catch, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
