dmvk commented on code in PR #22169:
URL: https://github.com/apache/flink/pull/22169#discussion_r1137422867
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerNG.java:
##########
@@ -185,4 +187,28 @@ void deliverOperatorEventToCoordinator(
*/
CompletableFuture<CoordinationResponse>
deliverCoordinationRequestToCoordinator(
OperatorID operator, CoordinationRequest request) throws
FlinkException;
+
+ /**
+ * Read current {@link JobResourceRequirements job resource requirements}.
+ *
+ * @return Current resource requirements.
+ */
+ default JobResourceRequirements requestJobResourceRequirements() {
+ throw new UnsupportedOperationException(
Review Comment:
I had that initially, but it felt bizarre because the scheduler doesn't
accept JRR, which could make the user wonder why it is even there.
Ultimately, I'd rather block the feature completely than expose incomplete
implementation.
@zentol @rkhachatryan, if you think this should still be added, I'm happy to
do that
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
