Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2425#discussion_r84029158
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java ---
    @@ -393,6 +399,24 @@ static void copyFromRecoveryPath(String recoveryPath, 
File localBlobFile) throws
        }
     
        /**
    +    * Utility method to validate secure cookie from Flink configuration 
instance
    +    * @throws
    +    */
    +   public static String validateAndGetSecureCookie(Configuration 
configuration) {
    +           String secureCookie = null;
    +           if(configuration.getBoolean(ConfigConstants.SECURITY_ENABLED, 
DEFAULT_SECURITY_ENABLED) == true) {
    +                   secureCookie = 
configuration.getString(ConfigConstants.SECURITY_COOKIE, null);
    +                   if(secureCookie == null) {
    +                           String message = "Missing " + 
ConfigConstants.SECURITY_COOKIE +
    +                                           " configuration in Flink 
configuration file";
    +                           LOG.error(message);
    +                           throw new RuntimeException(message);
    --- End diff --
    
    - Exceptions are logged anyways.
    - This should be `IllegalConfigurationException`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to