Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2425#discussion_r84036664
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestProtocol.java
---
@@ -30,16 +30,29 @@
private final NettyMessageEncoder messageEncoder = new
NettyMessageEncoder();
- private final NettyMessage.NettyMessageDecoder messageDecoder = new
NettyMessage.NettyMessageDecoder();
+ private final NettyMessage.NettyMessageDecoder serverMessageDecoder;
+
+ private final NettyMessage.NettyMessageDecoder clientMessageDecoder;
private final ResultPartitionProvider partitionProvider;
private final TaskEventDispatcher taskEventDispatcher;
private final NetworkBufferPool networkbufferPool;
+ private final String secureCookie;
- PartitionRequestProtocol(ResultPartitionProvider partitionProvider,
TaskEventDispatcher taskEventDispatcher, NetworkBufferPool networkbufferPool) {
+ PartitionRequestProtocol(ResultPartitionProvider partitionProvider,
TaskEventDispatcher taskEventDispatcher,
+ NetworkBufferPool
networkbufferPool, String secureCookie) {
this.partitionProvider = partitionProvider;
this.taskEventDispatcher = taskEventDispatcher;
this.networkbufferPool = networkbufferPool;
+ this.secureCookie = (secureCookie == null ||
secureCookie.length() == 0) ? "": secureCookie;
+
+ serverMessageDecoder = new
NettyMessage.NettyMessageDecoder(secureCookie);
+
+ /*
+ * Client decoder does not validate the secure cookie from
server since
+ * the server protocol does not transmit the secure cookie on
the wire
+ */
+ clientMessageDecoder = new
NettyMessage.NettyMessageDecoder(null);
--- End diff --
But it still sends an empty cookie?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
