tzulitai commented on code in PR #22481: URL: https://github.com/apache/flink/pull/22481#discussion_r1184399791
########## flink-formats/flink-orc/src/main/java/org/apache/flink/orc/writer/PhysicalWriterImpl.java: ########## @@ -1,398 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package org.apache.flink.orc.writer; - -import org.apache.flink.annotation.Internal; -import org.apache.flink.core.fs.FSDataOutputStream; - -import com.google.protobuf.CodedOutputStream; -import org.apache.orc.CompressionCodec; -import org.apache.orc.CompressionKind; -import org.apache.orc.OrcFile; -import org.apache.orc.OrcProto; -import org.apache.orc.PhysicalWriter; -import org.apache.orc.impl.HadoopShims; -import org.apache.orc.impl.OrcCodecPool; -import org.apache.orc.impl.OutStream; -import org.apache.orc.impl.StreamName; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - -import java.io.IOException; -import java.io.OutputStream; -import java.nio.ByteBuffer; -import java.util.ArrayList; -import java.util.List; -import java.util.Map; -import java.util.TreeMap; - -import static org.apache.orc.impl.WriterImpl.getEstimatedBufferSize; - -/** - * A slightly customised clone of {@link org.apache.orc.impl.PhysicalFsWriter}. - * - * <p>Whereas PhysicalFsWriter implementation works on the basis of a Path, this implementation - * leverages Flink's {@link FSDataOutputStream} to write the compressed data. - * - * <p>NOTE: If the ORC dependency version is updated, this file may have to be updated as well to be - * in sync with the new version's PhysicalFsWriter. Review Comment: @pgaref quick question before I dive deeper: I assume that the new `PhysicalFsWriter` using provided `FSDataOutputStream` has the exact same functionality as what was implemented with the original custom `PhysicalWriterImpl` and `NoHivePhysicalWriterImpl`? I did not do a line-by-line cross check, but for example, this Javadoc in the original `PhysicalWriterImpl` has me wondering. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
