pgaref commented on code in PR #22481: URL: https://github.com/apache/flink/pull/22481#discussion_r1184521758
########## flink-formats/flink-orc/src/main/java/org/apache/flink/orc/writer/NoCloseFSDataOutputStream.java: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.orc.writer; + +import org.apache.flink.annotation.Internal; + +import org.apache.hadoop.fs.FSDataOutputStream; + +import java.io.IOException; +import java.io.OutputStream; + +/** + * A slightly customised clone of {@link org.apache.hadoop.fs.FSDataOutputStream}. + * + * <p>This implementation does not close the underlying flink stream to avoid exceptions when + * checkpointing. + */ +@Internal +public class NoCloseFSDataOutputStream extends FSDataOutputStream { + + public NoCloseFSDataOutputStream(OutputStream out) throws IOException { + super(out); + } + + @Override + public void close() throws IOException { + // Don't close the internal stream here to avoid + // Stream Closed or ClosedChannelException when Flink performs checkpoint. Review Comment: Exactly, did no go deeper here as we are replicating the existing functionality. I also observed the `ClosedChannelException` issue when keeping the stream open in the existing tests, for example: https://github.com/apache/flink/blob/master/flink-formats/flink-orc/src/test/java/org/apache/flink/orc/OrcFileSystemITCase.java#L296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
