zentol commented on code in PR #22548:
URL: https://github.com/apache/flink/pull/22548#discussion_r1188563452
##########
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/executor/TestExecutorExtension.java:
##########
@@ -47,8 +58,26 @@ public T getExecutor() {
@Override
public void afterAll(ExtensionContext context) throws Exception {
+ gracefulShutdown(executorService, LOG);
+ }
+
+ static void gracefulShutdown(@Nullable ExecutorService executorService,
Logger logger) {
Review Comment:
I'm a bit worried that this might increase the duration of tests because now
affected tests sits idle for 10 seconds.
Why not just call shutdownNow immediately?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
