XComp commented on code in PR #22548: URL: https://github.com/apache/flink/pull/22548#discussion_r1189977494
########## flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/executor/TestExecutorExtension.java: ########## @@ -47,8 +58,26 @@ public T getExecutor() { @Override public void afterAll(ExtensionContext context) throws Exception { + gracefulShutdown(executorService, LOG); + } + + static void gracefulShutdown(@Nullable ExecutorService executorService, Logger logger) { Review Comment: That's true. But we could make this an opt-out feature. :thinking: But more generally asking: Don't you think that out-standing tasks that are left hanging might reveal some misbehavior in the test? I'm not passionate about that one and would be ok with using `shutdownNow()`. My only intention was to reveal issues in the code base that are missed right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org