ashangit commented on code in PR #590:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/590#discussion_r1190079103
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java:
##########
@@ -270,17 +270,13 @@ protected void rollback(FlinkResourceContext<CR> ctx)
throws Exception {
UpgradeMode upgradeMode = resource.getSpec().getJob().getUpgradeMode();
- cancelJob(
- ctx,
- upgradeMode == UpgradeMode.STATELESS
- ? UpgradeMode.STATELESS
- : UpgradeMode.LAST_STATE);
+ cancelJob(ctx, upgradeMode);
Review Comment:
I wanted to ensure that HA data is well deleted before to restoreJob for
rollback also.
It looks to me that we should apply same pattern for upgrade and rollback
relying only on the savepoint and ensuring HA data is here.
For ex. if the upgrade was linked to bump of flink version with some changes
in HA data not compatible with rollbacked flink version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
