gyfora commented on code in PR #590:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/590#discussion_r1190101168
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java:
##########
@@ -270,17 +270,13 @@ protected void rollback(FlinkResourceContext<CR> ctx)
throws Exception {
UpgradeMode upgradeMode = resource.getSpec().getJob().getUpgradeMode();
- cancelJob(
- ctx,
- upgradeMode == UpgradeMode.STATELESS
- ? UpgradeMode.STATELESS
- : UpgradeMode.LAST_STATE);
+ cancelJob(ctx, upgradeMode);
Review Comment:
It would be great if somehow we could reuse the upgrade logic completely for
rollbacks. I know this is a fairly complex change I am happy to discuss this
offline with you as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
