hanyuzheng7 commented on code in PR #22785: URL: https://github.com/apache/flink/pull/22785#discussion_r1242997039
########## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayOfStringArgumentTypeStrategy.java: ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.types.inference.strategies; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.functions.FunctionDefinition; +import org.apache.flink.table.types.DataType; +import org.apache.flink.table.types.inference.ArgumentTypeStrategy; +import org.apache.flink.table.types.inference.CallContext; +import org.apache.flink.table.types.inference.Signature.Argument; +import org.apache.flink.table.types.logical.ArrayType; +import org.apache.flink.table.types.logical.LogicalTypeRoot; + +import java.util.List; +import java.util.Objects; +import java.util.Optional; + +/** Strategy for an argument that must be an array of strings. */ +@Internal +public final class ArrayOfStringArgumentTypeStrategy implements ArgumentTypeStrategy { + + private final String constraintMessage; + + public ArrayOfStringArgumentTypeStrategy(String constraintMessage) { + this.constraintMessage = constraintMessage; + } + + @Override + public Optional<DataType> inferArgumentType( + CallContext callContext, int argumentPos, boolean throwOnFailure) { + + final List<DataType> actualDataTypes = callContext.getArgumentDataTypes(); + DataType actualType = actualDataTypes.get(argumentPos); + + // Check if the type is an array and its element is string + if (actualType.getLogicalType().getTypeRoot() == LogicalTypeRoot.ARRAY + && (((ArrayType) actualType.getLogicalType()).getElementType().getTypeRoot() + == LogicalTypeRoot.VARCHAR + || ((ArrayType) actualType.getLogicalType()).getElementType().getTypeRoot() + == LogicalTypeRoot.CHAR)) { + return Optional.of(actualType); + } Review Comment: fixed it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
