[
https://issues.apache.org/jira/browse/FLINK-32455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738503#comment-17738503
]
Yun Gao commented on FLINK-32455:
---------------------------------
May I first have a double confirmation on the direction we'd like to go:
1. As a whole, FLINK-27518 aims to avoid generating new snapshots for
migration tests manually on publishing new version. Since there are also
migration tests in the Kafka repo, I think it is also useful to also introduce
the improve here.
2. for the fink-migration-test-utils dependency, now it requires the module
using migration tests to introduce the dependency directly, thus it should also
not be a blocker.
If we think it is ok to go this way, I could open a PR to refactor the existing
migration tests to the new framework.
> Breaking change in TypeSerializerUpgradeTestBase prevents
> flink-connector-kafka from building against 1.18-SNAPSHOT
> -------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-32455
> URL: https://issues.apache.org/jira/browse/FLINK-32455
> Project: Flink
> Issue Type: Sub-task
> Components: Connectors / Kafka, Test Infrastructure
> Affects Versions: 1.18.0
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Priority: Blocker
> Fix For: 1.18.0
>
>
> FLINK-27518 introduced a breaking signature change to the abstract class
> {{TypeSerializerUpgradeTestBase}}, specifically the abstract
> {{createTestSpecifications}} method signature was changed. This breaks
> downstream test code in externalized connector repos, e.g.
> flink-connector-kafka's {{KafkaSerializerUpgradeTest}}
> Moreover, {{fink-migration-test-utils}} needs to be transitively pulled in by
> downstream test code that depends on flink-core test-jar.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
