[
https://issues.apache.org/jira/browse/FLINK-32455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740024#comment-17740024
]
Yun Gao commented on FLINK-32455:
---------------------------------
Thanks [~tzulitai] for the quick fix!
For the formal fix, I think we might also use the same option, namely we
# Revert the `TypeSerializerUpgradeTestBase` so the connectors libraries could
continue to use it.
# Introduce a new `MigratedTypeSerializerUpgradeTestBase` and make all the
tests inside flink library to use.
# Then after 1.18 get published, we could move
`MigratedTypeSerializerUpgradeTestBase` back to
`TypeSerializerUpgradeTestBase`, and also migrates the tests in the connector
libraries.
What do you think about this?
> Breaking change in TypeSerializerUpgradeTestBase prevents
> flink-connector-kafka from building against 1.18-SNAPSHOT
> -------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-32455
> URL: https://issues.apache.org/jira/browse/FLINK-32455
> Project: Flink
> Issue Type: Sub-task
> Components: Connectors / Kafka, Test Infrastructure
> Affects Versions: 1.18.0
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Priority: Blocker
> Fix For: 1.18.0
>
>
> FLINK-27518 introduced a breaking signature change to the abstract class
> {{TypeSerializerUpgradeTestBase}}, specifically the abstract
> {{createTestSpecifications}} method signature was changed. This breaks
> downstream test code in externalized connector repos, e.g.
> flink-connector-kafka's {{KafkaSerializerUpgradeTest}}
> Moreover, {{fink-migration-test-utils}} needs to be transitively pulled in by
> downstream test code that depends on flink-core test-jar.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
