[ https://issues.apache.org/jira/browse/FLINK-4887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612672#comment-15612672 ]
ASF GitHub Bot commented on FLINK-4887: --------------------------------------- Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2699#discussion_r85392726 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/messages/StackTrace.java --- @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.messages; + +import org.apache.flink.runtime.instance.InstanceID; +import org.apache.flink.util.Preconditions; + +public class StackTrace { --- End diff -- This also needs to be serializable > Replace ActorGateway by TaskManagerGateway interface > ---------------------------------------------------- > > Key: FLINK-4887 > URL: https://issues.apache.org/jira/browse/FLINK-4887 > Project: Flink > Issue Type: Bug > Affects Versions: 1.2.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Fix For: 1.2.0 > > > Instead of accessing directly on the {{ActorGateway}} in the {{Execution}} > and {{ExecutionVertex}} it would be better to decouple the two components by > introducing the {{TaskGateway}} interface which provides access to task > related rpc calls. The {{ActorGateway}} could be one implementation of the > interface. > This change will prepare the further implementation of Flip-6. -- This message was sent by Atlassian JIRA (v6.3.4#6332)