[
https://issues.apache.org/jira/browse/FLINK-4887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15622152#comment-15622152
]
ASF GitHub Bot commented on FLINK-4887:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2699#discussion_r85737529
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagerLogHandler.java
---
@@ -243,22 +284,29 @@ public void onSuccess(Object filePathOption) throws
Throwable {
@Override
public void
operationComplete(
io.netty.util.concurrent.Future<? super Void> future) throws Exception {
-
lastRequestPending.remove(taskManagerID);
-
fc.close();
-
raf.close();
+
lastRequestPending.remove(taskManagerID);
+
fc.close();
+
raf.close();
}
};
if
(ctx.pipeline().get(SslHandler.class) == null) {
ctx.write(
new
DefaultFileRegion(fc, 0, fileLength), ctx.newProgressivePromise())
-
.addListener(completionListener);
+
.addListener(completionListener);
--- End diff --
missing indent
> Replace ActorGateway by TaskManagerGateway interface
> ----------------------------------------------------
>
> Key: FLINK-4887
> URL: https://issues.apache.org/jira/browse/FLINK-4887
> Project: Flink
> Issue Type: Bug
> Affects Versions: 1.2.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Fix For: 1.2.0
>
>
> Instead of accessing directly on the {{ActorGateway}} in the {{Execution}}
> and {{ExecutionVertex}} it would be better to decouple the two components by
> introducing the {{TaskGateway}} interface which provides access to task
> related rpc calls. The {{ActorGateway}} could be one implementation of the
> interface.
> This change will prepare the further implementation of Flip-6.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
