[ 
https://issues.apache.org/jira/browse/FLINK-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633099#comment-15633099
 ] 

ASF GitHub Bot commented on FLINK-3702:
---------------------------------------

Github user mbalassi commented on the issue:

    https://github.com/apache/flink/pull/2094
  
    As @fhueske and @StephanEwen has suggested I have refactored @ggevay's code 
and now instead of adding two methods to the `TypeInformation` I have moved the 
functionality to a `FieldAccessorFactory` class.
    
    To achieve this I had to move the code back to `flink-streaming-java` as 
the static factory needs to import `scala.Product` to implement the 
functionality for case classes. Given that a scala dependency is better avoided 
at this point in `flink-core` and `flink-streaming` already has the scala 
dependency I felt the most comfortable with this approach. 
    
    If we decide to use the `FieldAccessor`s in other parts of the system we 
might need to revert back to Gabor's previous approach based on inheritance 
instead of the current static monstrosity, so that we can separate the scala 
utilities into their respective projects.
    
    I have also addressed Fabian's inline comments. 


> DataStream API PojoFieldAccessor doesn't support nested POJOs
> -------------------------------------------------------------
>
>                 Key: FLINK-3702
>                 URL: https://issues.apache.org/jira/browse/FLINK-3702
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>    Affects Versions: 1.0.0
>            Reporter: Robert Metzger
>            Assignee: Gabor Gevay
>
> The {{PojoFieldAccessor}} (which is used by {{.sum(String)}} and similar 
> methods) doesn't support nested POJOs right now.
> As part of FLINK-3697 I'll add a check for a nested POJO and fail with an 
> exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to