1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1366402713
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##########
@@ -1162,16 +1167,24 @@ private ExecutionGraph
createExecutionGraphAndRestoreState(
LOG);
}
+ /**
+ * In regular mode, rescale the job if added resource meets {@link
+ * JobManagerOptions#MIN_PARALLELISM_INCREASE}. In force mode rescale if
the parallelism has
+ * changed.
+ */
@Override
- public boolean shouldRescale(ExecutionGraph executionGraph) {
+ public boolean shouldRescale(ExecutionGraph executionGraph, boolean
forceRescale) {
Review Comment:
> The only thing that this boolean parameter adds is a change of
RescallingController.
That's exactly I want to test. Check whether the right RescallingController
is selected when `forceRescale` is true and false. IIUC, it's tested for now.
> Both the RescallingControllers are covered by tests and the behavior of
forceRescale is tested in the ExecutingTest class.
IIUC, you have tested 2 types of RescallingControllers individually. In
ExecutingTest, you just mock the `shouldRescale()` and the real `shouldRescale`
isn't tested.
Please correct me if my understanding is wrong, thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
