echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1368585344
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##########
@@ -1162,16 +1167,24 @@ private ExecutionGraph
createExecutionGraphAndRestoreState(
LOG);
}
+ /**
+ * In regular mode, rescale the job if added resource meets {@link
+ * JobManagerOptions#MIN_PARALLELISM_INCREASE}. In force mode rescale if
the parallelism has
+ * changed.
+ */
@Override
- public boolean shouldRescale(ExecutionGraph executionGraph) {
+ public boolean shouldRescale(ExecutionGraph executionGraph, boolean
forceRescale) {
Review Comment:
> That's exactly I want to test. Check whether the right
RescallingController is selected when forceRescale is true and false. IIUC,
it's tested for now.
well, testing that is equivalent to testing the ternary expression
`RescalingControllerrescalingControllerToUse = forceRescale ?
forceRescalingController : rescalingController` which is a JDK built-in. As a
consequence, that still seems unnecessary to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
