snuyanzin commented on code in PR #73:
URL:
https://github.com/apache/flink-connector-jdbc/pull/73#discussion_r1373838435
##########
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/internal/JdbcOutputSerializerTest.java:
##########
@@ -0,0 +1,36 @@
+package org.apache.flink.connector.jdbc.internal;
+
+import org.apache.flink.api.common.ExecutionConfig;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.types.Row;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotEquals;
Review Comment:
since in most of the places there is
`org.assertj.core.api.Assertions.assertThat;` and IIRC somewhere in Flink guide
it was mentioned that it's better to use
`org.assertj.core.api.Assertions.assertThat;`
could we use it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
