snuyanzin commented on code in PR #73:
URL:
https://github.com/apache/flink-connector-jdbc/pull/73#discussion_r1373843729
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcOutputFormatBuilder.java:
##########
@@ -100,10 +98,7 @@ public JdbcOutputFormatBuilder setFieldDataTypes(DataType[]
fieldDataTypes) {
return new JdbcOutputFormat<>(
new SimpleJdbcConnectionProvider(jdbcOptions),
executionOptions,
- ctx ->
- createBufferReduceExecutor(
- dmlOptions, ctx, rowDataTypeInformation,
logicalTypes),
Review Comment:
since all the usages of `rowDataTypeInformation` are removed, could we
remove the field itself?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
