RocMarshal commented on code in PR #23635:
URL: https://github.com/apache/flink/pull/23635#discussion_r1381224693
##########
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java:
##########
@@ -708,6 +708,20 @@ public class TaskManagerOptions {
"Time we wait for the timers in milliseconds to
finish all pending timer threads"
+ " when the stream task is cancelled.");
+ public static final ConfigOption<TaskManagerLoadBalanceMode>
TASK_MANAGER_LOAD_BALANCE_MODE =
Review Comment:
hi, @1996fanrui Thanks for the idea. There's nothing better!
>After this FLIP is merged, if a job with cluster.evenly-spread-out-slots:
true, and didn't set the taskmanager.load-
>balance.mode. Should we change the default value from None to Slots?
Yes, I'd prefer to be compatible with old configuration item.
- This can provide users with a smooth over experience
- Removing the old configuration item requires a process for evolution. For
example, after one or two editions, we will completely discard the old
configuration item.
I'd create this JIRA ticket and advance the related work if there's nothing
ambiguous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
