1996fanrui commented on code in PR #721: URL: https://github.com/apache/flink-kubernetes-operator/pull/721#discussion_r1412210561
########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java: ########## @@ -180,13 +190,28 @@ public void reconcile(FlinkResourceContext<CR> ctx) throws Exception { } } - private void applyAutoscaler(FlinkResourceContext<CR> ctx) throws Exception { + private void applyAutoscaler(FlinkResourceContext<CR> ctx, @Nullable String existingOverrides) + throws Exception { var autoScalerCtx = ctx.getJobAutoScalerContext(); boolean autoscalerEnabled = ctx.getResource().getSpec().getJob() != null && ctx.getObserveConfig().getBoolean(AUTOSCALER_ENABLED); autoScalerCtx.getConfiguration().set(AUTOSCALER_ENABLED, autoscalerEnabled); + autoscaler.scale(autoScalerCtx); Review Comment: If I understand correct. The root cause is the logic related to `boolean specChanged` in `AbstractFlinkResourceReconciler#reconcile`. The `specChanged` will be true, when the ordering of the parallelism overrides is changed. And operator will scale job. Right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org