mxm commented on code in PR #721:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/721#discussion_r1414078197
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java:
##########
@@ -186,7 +187,41 @@ private void applyAutoscaler(FlinkResourceContext<CR> ctx)
throws Exception {
ctx.getResource().getSpec().getJob() != null
&&
ctx.getObserveConfig().getBoolean(AUTOSCALER_ENABLED);
autoScalerCtx.getConfiguration().set(AUTOSCALER_ENABLED,
autoscalerEnabled);
+
autoscaler.scale(autoScalerCtx);
+ putBackOldParallelismOverridesIfNewOnesAreMerelyAPermutation(ctx);
+ }
+
+ private static <
+ CR extends AbstractFlinkResource<SPEC, STATUS>,
+ SPEC extends AbstractFlinkSpec,
+ STATUS extends CommonStatus<SPEC>>
+ void putBackOldParallelismOverridesIfNewOnesAreMerelyAPermutation(
Review Comment:
Also
https://github.com/apache/flink-kubernetes-operator/commit/158cbe29169cbfb7fa7ad676fb0273fd7ef6d25e
does not introduce the problem. It fixes it at the cost of restarting once
instead of every time we redeploy the operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
