Jiabao-Sun commented on PR #23876: URL: https://github.com/apache/flink/pull/23876#issuecomment-1851908472
Thanks @mbalassi, please continue with the merge. Just some insignificant thoughts, please ignore it. > To obtain a proper class hierarchy, we added a new interface `InitContext` and made `CommitterInitContext` and `WriterInitContext` inherit from it. Obviously, in the inheritance structure, it would be more reasonable for `WriterInitContext` to have a symmetric name. However, for compatibility reasons, we had to change `WriterInitContext` back to `InitContext`. This approach will increase the understanding cost for developers as to why there are two `InitContext`s. In addition, the newly added `InitContext` looks very similar to `RuntimeContext`, may also be unnecessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
