pvary commented on PR #23876: URL: https://github.com/apache/flink/pull/23876#issuecomment-1852050556
Thanks @mbalassi for the merge and @gyfora, @reswqa, @becketqin, @leonardBang, @Jiabao-Sun for the reviews @Jiabao-Sun: While I partially agree with your comments (my original PR #23555 was like that), I think that if we have 2 interfaces where about half of the methods are the same, then we might want to have a common interface and inherit from there. The good thing is that the [FLIP-372](https://cwiki.apache.org/confluence/display/FLINK/FLIP-372%3A+Allow+TwoPhaseCommittingSink+WithPreCommitTopology+to+alter+the+type+of+the+Committable) and the corresponding [discussion](https://lists.apache.org/thread/344pzbrqbbb4w0sfj67km25msp7hxlyd) is still open, so we can continue this debate there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
