flashJd commented on code in PR #728:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1425382922
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java:
##########
@@ -72,6 +72,15 @@ private static ConfigOptions.OptionBuilder
autoScalerConfig(String key) {
.withDescription(
"Stabilization period in which no new scaling will
be executed");
+ public static final ConfigOption<List<String>> FORBID_PERIOD =
+ autoScalerConfig("forbid.periods")
+ .stringType()
+ .asList()
+ .defaultValues()
+
.withDeprecatedKeys(deprecatedOperatorConfigKey("forbid.periods"))
+ .withDescription(
+ "A (semicolon-separated) list of certain times of
the day during which autoscaling is forbidden,
10:00:00-11:00:00;21:30:00-22:30:00 for example");
Review Comment:
I checked the pr
https://github.com/apache/flink-kubernetes-operator/pull/656 which introduced
`class CronExpression` from log4j-core and log4j-core copied from Quartz.
1. So can we set the `excluded periods` config to be a cron expression
string and use it's `isSatisfiedBy(final Date date)` method to judge whether in
excluded periods
2. Since standardized cron string doesn't contain a timeZone, should we
just use the default timeZone or some other way to pass it in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
